Convert chipflow.toml parsing to pydantic #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
robtaylor
force-pushed
the
toml-to-pydantic
branch
from
5453d23 to
08dc3e4
Compare
robtaylor
force-pushed
the
toml-to-pydantic
branch
2 times, most recently
from
476a890 to
a47e4a5
Compare
robtaylor
commented
Mar 18, 2025
Contributor
Author
robtaylor
left a comment
robtaylor
left a comment
There was a problem hiding this comment.
Looks good to me
gatecat
reviewed
Mar 18, 2025
Contributor
Author
|
Nope, good catch!
…On Tue, 18 Mar 2025 at 15:05, myrtle ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
On pytest.xml
<#56 (comment)>:
Is this file supposed to be committed?
—
Reply to this email directly, view it on GitHub
<#56 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB4O4GM5GCY774RHU77WJ32VAY2XAVCNFSM6AAAAABZEEACJ6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMOJUHE3DCNRXGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
robtaylor
force-pushed
the
toml-to-pydantic
branch
from
a47e4a5 to
b793182
Compare
- Remove unused variable assignment that was triggering F841 lint error - Simply validate the config_dict without capturing the result 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Contributor
Author
|
I fixed the lint error that was causing the CI to fail. The issue was an unused 'config' variable in init.py. I modified the code to simply validate the config_dict without capturing the result, which fixes the F841 lint error. All checks are now passing! |
gatecat
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close #32